Skip to content

Fix: Naming Changes#36

Merged
sephynox merged 1 commit into
mainfrom
fix/naming-updates
Jul 9, 2026
Merged

Fix: Naming Changes#36
sephynox merged 1 commit into
mainfrom
fix/naming-updates

Conversation

@sephynox

@sephynox sephynox commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Better align some method names.


Note

Medium Risk
Breaking renames across all public SDK surfaces (WASM/JS, WASI flat ABI, WIT, Java); integrators must update call sites, though on-chain identifiers are unchanged.

Overview
Renames account identity APIs across bindings, WASM, WASI (P1/P2/WIT), and Java so they match the reference SDK: address / fromAddress / account_from_address become publicKeyString, fromPublicKeyString, and account_from_public_key_string (the keeta_… string). Error codes shift from INVALID_ADDRESS to INVALID_PUBLIC_KEY_STRING.

Adds fromPublicKeyAndType / publicKeyAndTypeString for the 0x-prefixed [key_type_byte || raw_public_key] layout, with round-trip tests in Rust, P1/P2 host tests, WASM Playwright, and Java parity harnesses.

Account.fromSeed now accepts an optional algorithm (default ecdsa_secp256k1) in WIT, P2, and P1 (empty algo string); Java gains a two-arg account(seed, index) overload.

keetanetwork-client OpenAPI responses are refactored into named component schemas; Java vote client uses CreateVoteResponse instead of CreateVote200Response. Crate versions are bumped (notably keetanetwork-client-wasi 0.5.0).

Reviewed by Cursor Bugbot for commit c7c33dc. Bugbot is set up for automated code reviews on this repo. Configure here.

@sephynox sephynox self-assigned this Jul 9, 2026
@sephynox sephynox added enhancement New feature or request release labels Jul 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

@sephynox sephynox merged commit b2d3e38 into main Jul 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant